]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2491] Use insert instead of memcpy to append to a vector.
authorMarcin Siodelski <marcin@isc.org>
Mon, 10 Dec 2012 17:32:42 +0000 (18:32 +0100)
committerMarcin Siodelski <marcin@isc.org>
Mon, 10 Dec 2012 17:32:42 +0000 (18:32 +0100)
src/lib/dhcp/option_data_types.cc

index a0e29aa04202d9890d7d332dec76ec44c97a1160..ce6f8c2cb9e0085409659b137b5e0844050e7296 100644 (file)
@@ -236,11 +236,9 @@ OptionDataTypeUtil::writeFqdn(const std::string& fqdn,
         isc::dns::Name name(fqdn);
         isc::dns::LabelSequence labels(name);
         if (labels.getDataLength() > 0) {
-            buf.resize(buf.size() + labels.getDataLength());
             size_t read_len = 0;
             const uint8_t* data = labels.getData(&read_len);
-            memcpy(static_cast<void*>(&buf[buf.size() - read_len]),
-                   data, read_len);
+            buf.insert(buf.end(), data, data + read_len);
         }
     } catch (const isc::Exception& ex) {
         isc_throw(BadDataTypeCast, ex.what());