channel: Fix clang-tidy warnings

diff --git a/pdns/channel.cc b/pdns/channel.cc
index 9b820437d53c2e97209d6506a7620ffdadb2c2f8..5892f9e0f8811136c8c88dc6719b4718aba78b5d 100644 (file)
--- a/pdns/channel.cc
+++ b/pdns/channel.cc
@@ -110,6 +110,6 @@ std::pair<Notifier, Waiter> createNotificationQueue(bool nonBlocking, size_t pip
     setPipeBufferSize(receiver.getHandle(), pipeBufferSize);
   }
 
-  return std::pair(Notifier(std::move(sender)), Waiter(std::move(receiver), throwOnEOF));
+  return {Notifier(std::move(sender)), Waiter(std::move(receiver), throwOnEOF)};
 }
 }

diff --git a/pdns/test-channel.cc b/pdns/test-channel.cc
index 500db1fb68f4041bd8d94bb554f3e9a7377f1d03..6965eecdbf67807c82cdf2298ee625dab4adc7c5 100644 (file)
--- a/pdns/test-channel.cc
+++ b/pdns/test-channel.cc
@@ -46,7 +46,7 @@ BOOST_AUTO_TEST_CASE(test_object_queue_full)
   while (!blocked) {
     auto obj = std::make_unique<MyObject>();
     obj->a = 42U;
-    blocked = sender.send(std::move(obj)) == false;
+    blocked = !sender.send(std::move(obj));
     if (blocked) {
       BOOST_CHECK(obj);
     }