]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Improve global state for options.
authorMartin Liska <mliska@suse.cz>
Wed, 10 Mar 2021 14:12:31 +0000 (15:12 +0100)
committerMartin Liska <mliska@suse.cz>
Tue, 25 May 2021 12:57:03 +0000 (14:57 +0200)
gcc/c-family/ChangeLog:

PR tree-optimization/92860
PR target/99592
* c-attribs.c (handle_optimize_attribute): Save target node
before calling parse_optimize_options and save it in case
it changes.
* c-pragma.c (handle_pragma_target): Similarly for pragma.
(handle_pragma_pop_options): Likewise here.

gcc/ChangeLog:

PR tree-optimization/92860
PR target/99592
* optc-save-gen.awk: Remove exceptions.

gcc/c-family/c-attribs.c
gcc/c-family/c-pragma.c
gcc/optc-save-gen.awk

index 671b27c3200596b6b330f752f56c09b724c128b9..804374d5acc8951101f3ff6bbbd7dcb9b430ef27 100644 (file)
@@ -5383,6 +5383,8 @@ handle_optimize_attribute (tree *node, tree name, tree args,
 
       /* Save current options.  */
       cl_optimization_save (&cur_opts, &global_options, &global_options_set);
+      tree prev_target_node = build_target_option_node (&global_options,
+                                                       &global_options_set);
 
       /* If we previously had some optimization options, use them as the
         default.  */
@@ -5401,10 +5403,17 @@ handle_optimize_attribute (tree *node, tree name, tree args,
       parse_optimize_options (args, true);
       DECL_FUNCTION_SPECIFIC_OPTIMIZATION (*node)
        = build_optimization_node (&global_options, &global_options_set);
+      tree target_node = build_target_option_node (&global_options,
+                                                  &global_options_set);
+      if (prev_target_node != target_node)
+       DECL_FUNCTION_SPECIFIC_TARGET (*node) = target_node;
 
       /* Restore current options.  */
       cl_optimization_restore (&global_options, &global_options_set,
                               &cur_opts);
+      cl_target_option_restore (&global_options, &global_options_set,
+                               TREE_TARGET_OPTION (prev_target_node));
+
       if (saved_global_options != NULL)
        {
          cl_optimization_compare (saved_global_options, &global_options);
index 4f8e8e0128c3ddb77450a0d4976d00ad03c6a4c6..7f658ea564680f5dd0e7c4b5ffc86281f3cfd321 100644 (file)
@@ -918,6 +918,12 @@ handle_pragma_target(cpp_reader *ARG_UNUSED(dummy))
 
       if (targetm.target_option.pragma_parse (args, NULL_TREE))
        current_target_pragma = chainon (current_target_pragma, args);
+
+      /* A target pragma can also influence optimization options. */
+      tree current_optimize
+       = build_optimization_node (&global_options, &global_options_set);
+      if (current_optimize != optimization_current_node)
+       optimization_current_node = current_optimize;
     }
 }
 
@@ -1078,12 +1084,14 @@ handle_pragma_pop_options (cpp_reader *ARG_UNUSED(dummy))
       target_option_current_node = p->target_binary;
     }
 
+  /* Always restore optimization options as optimization_current_node is
+   * overwritten by invoke_set_current_function_hook.  */
+  cl_optimization_restore (&global_options, &global_options_set,
+                          TREE_OPTIMIZATION (p->optimize_binary));
+
   if (p->optimize_binary != optimization_current_node)
     {
-      tree old_optimize = optimization_current_node;
-      cl_optimization_restore (&global_options, &global_options_set,
-                              TREE_OPTIMIZATION (p->optimize_binary));
-      c_cpp_builtins_optimize_pragma (parse_in, old_optimize,
+      c_cpp_builtins_optimize_pragma (parse_in, optimization_current_node,
                                      p->optimize_binary);
       optimization_current_node = p->optimize_binary;
     }
index 19afa895930b2554d69b8f77f282bd20c33600a4..e2a9a496bfde5b1b72e180a4d5b228d359fa1530 100644 (file)
@@ -1438,19 +1438,10 @@ print "{"
 checked_options["flag_merge_constants"]++
 checked_options["param_max_fields_for_field_sensitive"]++
 checked_options["flag_omit_frame_pointer"]++
-checked_options["unroll_only_small_loops"]++
 # arc exceptions
 checked_options["TARGET_ALIGN_CALL"]++
 checked_options["TARGET_CASE_VECTOR_PC_RELATIVE"]++
 checked_options["arc_size_opt_level"]++
-# arm exceptions
-checked_options["arm_fp16_format"]++
-checked_options["flag_ipa_ra"]++
-# s390 exceptions
-checked_options["param_max_completely_peel_times"]++
-checked_options["param_max_completely_peeled_insns"]++
-checked_options["param_max_unroll_times"]++
-checked_options["param_max_unrolled_insns"]++
 
 
 for (i = 0; i < n_opts; i++) {