iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value...

[ Upstream commit 0af1c801a15225304a6328258efbf2bee245c654 ]

The data used is all in local variables so there is no advantage
in setting *val = ret with the direct mode claim held.
Move it later to after error check.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250217141630.897334-13-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Stable-dep-of: 8236644f5ecb ("iio: adc: ad7768-1: Fix conversion result sign")
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
index 4afa50e5c058a68b2294fd5c38b735d3b3dcca7d..c409b498fc31337bc9470fefd765254dfc4bbcd0 100644 (file)
--- a/drivers/iio/adc/ad7768-1.c
+++ b/drivers/iio/adc/ad7768-1.c
@@ -369,12 +369,11 @@ static int ad7768_read_raw(struct iio_dev *indio_dev,
                        return ret;
 
                ret = ad7768_scan_direct(indio_dev);
-               if (ret >= 0)
-                       *val = ret;
 
                iio_device_release_direct_mode(indio_dev);
                if (ret < 0)
                        return ret;
+               *val = ret;
 
                return IIO_VAL_INT;