]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
irqchip/armada-370-xp: Do not allow mapping IRQ 0 and 1
authorPali Rohár <pali@kernel.org>
Fri, 21 Jun 2024 09:38:28 +0000 (11:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Sep 2024 09:06:45 +0000 (11:06 +0200)
[ Upstream commit 3cef738208e5c3cb7084e208caf9bbf684f24feb ]

IRQs 0 (IPI) and 1 (MSI) are handled internally by this driver,
generic_handle_domain_irq() is never called for these IRQs.

Disallow mapping these IRQs.

[ Marek: changed commit message ]

Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-armada-370-xp.c

index c76fb70c70bb6d6a5524b939392c16bd8140229b..e865a43428b8384e441b5c82365e1e7ca32af5ca 100644 (file)
@@ -546,6 +546,10 @@ static struct irq_chip armada_370_xp_irq_chip = {
 static int armada_370_xp_mpic_irq_map(struct irq_domain *h,
                                      unsigned int virq, irq_hw_number_t hw)
 {
+       /* IRQs 0 and 1 cannot be mapped, they are handled internally */
+       if (hw <= 1)
+               return -EINVAL;
+
        armada_370_xp_irq_mask(irq_get_irq_data(virq));
        if (!is_percpu_irq(hw))
                writel(hw, per_cpu_int_base +