]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
dsync: Removed the new message counter. It wasn't working very well.
authorTimo Sirainen <tss@iki.fi>
Fri, 2 Jul 2010 12:51:26 +0000 (13:51 +0100)
committerTimo Sirainen <tss@iki.fi>
Fri, 2 Jul 2010 12:51:26 +0000 (13:51 +0100)
Especiall with remote connections it went quickly through, even though it
could still take minutes to actually transfer all the data.

--HG--
branch : HEAD

src/dsync/dsync-brain-msgs-new.c

index c8f08252ec90db482123ed3ff123add8de4987bd..40174193370b1cc482433473a6fbff330c1c089c 100644 (file)
@@ -34,8 +34,6 @@
 #include "dsync-worker.h"
 #include "dsync-brain-private.h"
 
-#include <stdio.h>
-
 struct dsync_brain_msg_copy_context {
        struct dsync_brain_msg_iter *iter;
        unsigned int msg_idx;
@@ -182,20 +180,13 @@ dsync_brain_mailbox_add_new_msgs(struct dsync_brain_msg_iter *iter,
                                 const mailbox_guid_t *mailbox_guid)
 {
        struct dsync_brain_new_msg *msgs;
-       unsigned int msg_count, n = 0;
-       bool output_stats = iter->sync->brain->verbose &&
-               iter->sync->brain->stdout_tty;
+       unsigned int msg_count;
        bool ret = TRUE;
 
        msgs = array_get_modifiable(&iter->new_msgs, &msg_count);
        while (iter->next_new_msg < msg_count) {
                struct dsync_brain_new_msg *msg = &msgs[iter->next_new_msg];
 
-               if (output_stats && (n++ % 10) == 0) {
-                       printf("\r%u/%u", iter->next_new_msg, msg_count);
-                       fflush(stdout);
-               }
-
                if (msg->mailbox_idx != iter->mailbox_idx) {
                        i_assert(msg->mailbox_idx > iter->mailbox_idx);
                        ret = FALSE;
@@ -212,11 +203,8 @@ dsync_brain_mailbox_add_new_msgs(struct dsync_brain_msg_iter *iter,
                        break;
                }
        }
-       if (iter->next_new_msg == msg_count) {
-               if (output_stats)
-                       printf("\r%u msgs saved\n", msg_count);
+       if (iter->next_new_msg == msg_count)
                ret = FALSE;
-       }
 
        /* flush copy commands */
        if (dsync_worker_output_flush(iter->worker) > 0 && ret) {
@@ -376,7 +364,6 @@ dsync_brain_msg_iter_sync_new_msgs(struct dsync_brain_msg_iter *iter)
 
 void dsync_brain_msg_sync_new_msgs(struct dsync_brain_mailbox_sync *sync)
 {
-       printf("Syncing new messages:\n");
        dsync_brain_msg_iter_sync_new_msgs(sync->src_msg_iter);
        dsync_brain_msg_iter_sync_new_msgs(sync->dest_msg_iter);
 }