]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netfilter: ctnetlink: Support offloaded conntrack entry deletion
authorPaul Blakey <paulb@nvidia.com>
Wed, 22 Mar 2023 07:35:32 +0000 (09:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 5 Jun 2023 06:17:33 +0000 (08:17 +0200)
commit 9b7c68b3911aef84afa4cbfc31bce20f10570d51 upstream.

Currently, offloaded conntrack entries (flows) can only be deleted
after they are removed from offload, which is either by timeout,
tcp state change or tc ct rule deletion. This can cause issues for
users wishing to manually delete or flush existing entries.

Support deletion of offloaded conntrack entries.

Example usage:
 # Delete all offloaded (and non offloaded) conntrack entries
 # whose source address is 1.2.3.4
 $ conntrack -D -s 1.2.3.4
 # Delete all entries
 $ conntrack -F

Signed-off-by: Paul Blakey <paulb@nvidia.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Cc: Demi Marie Obenour <demi@invisiblethingslab.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_conntrack_netlink.c

index 4747daf901e714a39a7c0084d4e5a296361067b3..754f473ce3de4d6af2e57f1d515e1ad14892bca0 100644 (file)
@@ -1229,9 +1229,6 @@ static const struct nla_policy ct_nla_policy[CTA_MAX+1] = {
 
 static int ctnetlink_flush_iterate(struct nf_conn *ct, void *data)
 {
-       if (test_bit(IPS_OFFLOAD_BIT, &ct->status))
-               return 0;
-
        return ctnetlink_filter_match(ct, data);
 }
 
@@ -1294,11 +1291,6 @@ static int ctnetlink_del_conntrack(struct net *net, struct sock *ctnl,
 
        ct = nf_ct_tuplehash_to_ctrack(h);
 
-       if (test_bit(IPS_OFFLOAD_BIT, &ct->status)) {
-               nf_ct_put(ct);
-               return -EBUSY;
-       }
-
        if (cda[CTA_ID]) {
                __be32 id = nla_get_be32(cda[CTA_ID]);