]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:smbd: Remove unreachable code (CID 710840)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Fri, 6 Oct 2023 01:02:42 +0000 (14:02 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 2 Nov 2023 03:08:37 +0000 (03:08 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/smbd/smb2_ioctl.c

index 2ca53e337883d358890c001884f1c4c375786d98..7d0f11df1ad1bb477ec1c3b9c14e496d94c2785c 100644 (file)
@@ -454,19 +454,14 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
        switch (in_ctl_code & IOCTL_DEV_TYPE_MASK) {
        case FSCTL_DFS:
                return smb2_ioctl_dfs(in_ctl_code, ev, req, state);
-               break;
        case FSCTL_FILESYSTEM:
                return smb2_ioctl_filesys(in_ctl_code, ev, req, state);
-               break;
        case FSCTL_NAMED_PIPE:
                return smb2_ioctl_named_pipe(in_ctl_code, ev, req, state);
-               break;
        case FSCTL_NETWORK_FILESYSTEM:
                return smb2_ioctl_network_fs(in_ctl_code, ev, req, state);
-               break;
        case FSCTL_SMBTORTURE:
                return smb2_ioctl_smbtorture(in_ctl_code, ev, req, state);
-               break;
        default:
                if (IS_IPC(smbreq->conn)) {
                        tevent_req_nterror(req, NT_STATUS_FS_DRIVER_REQUIRED);
@@ -475,11 +470,7 @@ static struct tevent_req *smbd_smb2_ioctl_send(TALLOC_CTX *mem_ctx,
                }
 
                return tevent_req_post(req, ev);
-               break;
        }
-
-       tevent_req_nterror(req, NT_STATUS_INTERNAL_ERROR);
-       return tevent_req_post(req, ev);
 }
 
 static NTSTATUS smbd_smb2_ioctl_recv(struct tevent_req *req,