]> git.ipfire.org Git - thirdparty/dbus.git/commitdiff
dbus-spawn: assert impossible returns from read functions don't happen
authorSimon McVittie <simon.mcvittie@collabora.co.uk>
Tue, 17 Jan 2017 20:28:15 +0000 (20:28 +0000)
committerSimon McVittie <smcv@collabora.com>
Fri, 7 Apr 2017 11:06:50 +0000 (12:06 +0100)
This silences -Wswitch-default.

Based on a patch from Thomas Zimmermann.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=98191

dbus/dbus-spawn.c

index 655bfe92d8d9a07e36048aad945577f78139307e..3c721d6f54ecf249d8f6a9251a3822ab20941689 100644 (file)
@@ -429,6 +429,10 @@ read_data (DBusBabysitter *sitter,
 
     case READ_STATUS_OK:
       break;
+
+    default:
+      _dbus_assert_not_reached ("invalid ReadStatus");
+      break;
     }
   
   if (got == 1)
@@ -453,6 +457,9 @@ read_data (DBusBabysitter *sitter,
                 return r;
               case READ_STATUS_OK:
                 break;
+              default:
+                _dbus_assert_not_reached ("invalid ReadStatus");
+                break;
               }
             
             if (got == 1)
@@ -513,6 +520,9 @@ read_data (DBusBabysitter *sitter,
                 return r;
               case READ_STATUS_OK:
                 break;
+              default:
+                _dbus_assert_not_reached ("invalid ReadStatus");
+                break;
               }
             
             sitter->grandchild_pid = pid;