]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
bpo-41336: Fix the error handling in zoneinfo_new_instance() (GH-21546)
authorZackery Spytz <zspytz@gmail.com>
Mon, 20 Jul 2020 12:51:26 +0000 (06:51 -0600)
committerGitHub <noreply@github.com>
Mon, 20 Jul 2020 12:51:26 +0000 (15:51 +0300)
Do not call PyObject_CallMethod() with a live exception (like
KeyboardInterrupt).

Modules/_zoneinfo.c

index 319d6c7b7760e2e52f244db9c7cfa1de1d584711..bee84cbf8f9f422f226979c5766c473bcb9e5c99 100644 (file)
@@ -224,8 +224,14 @@ error:
     self = NULL;
 cleanup:
     if (file_obj != NULL) {
+        PyObject *exc, *val, *tb;
+        PyErr_Fetch(&exc, &val, &tb);
         PyObject *tmp = PyObject_CallMethod(file_obj, "close", NULL);
-        Py_DECREF(tmp);
+        _PyErr_ChainExceptions(exc, val, tb);
+        if (tmp == NULL) {
+            Py_CLEAR(self);
+        }
+        Py_XDECREF(tmp);
         Py_DECREF(file_obj);
     }
     Py_DECREF(file_path);