btrfs: fix invalid leaf access in btrfs_quota_enable() if ref key not found

If btrfs_search_slot_for_read() returns 1, it means we did not find any
key greater than or equals to the key we asked for, meaning we have
reached the end of the tree and therefore the path is not valid. If
this happens we need to break out of the loop and stop, instead of
continuing and accessing an invalid path.

Fixes: 5223cc60b40a ("btrfs: drop the path before adding qgroup items when enabling qgroups")
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index f53c313ab6e4600e3edcb4cf1927a4f79440e691..38adadb936dc247a9273f65d3ef5e457296d606b 100644 (file)
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -1169,11 +1169,14 @@ int btrfs_quota_enable(struct btrfs_fs_info *fs_info,
                        }
                        if (ret > 0) {
                                /*
-                                * Shouldn't happen, but in case it does we
-                                * don't need to do the btrfs_next_item, just
-                                * continue.
+                                * Shouldn't happen because the key should still
+                                * be there (return 0), but in case it does it
+                                * means we have reached the end of the tree -
+                                * there are no more leaves with items that have
+                                * a key greater than or equals to @found_key,
+                                * so just stop the search loop.
                                 */
-                               continue;
+                               break;
                        }
                }
                ret = btrfs_next_item(tree_root, path);