]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-133904: Fix `math.factorial` documentation (GH-133907) (#133918)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 12 May 2025 12:53:44 +0000 (14:53 +0200)
committerGitHub <noreply@github.com>
Mon, 12 May 2025 12:53:44 +0000 (12:53 +0000)
gh-133904: Fix `math.factorial` documentation (GH-133907)
(cherry picked from commit 27ed64575d34f04029ba1d353810f3db4f4f045b)

Co-authored-by: mkaraev <maruf.karaev97@gmail.com>
Co-authored-by: sobolevn <mail@sobolevn.me>
Doc/library/math.rst
Modules/clinic/mathmodule.c.h
Modules/mathmodule.c

index 0749367045dfa9e91b778459773d9f98b6c9e8fc..394a462b9468e5e628d2715aeaf049da0475589e 100644 (file)
@@ -144,8 +144,7 @@ Number-theoretic functions
 
 .. function:: factorial(n)
 
-   Return *n* factorial as an integer.  Raises :exc:`ValueError` if *n* is not integral or
-   is negative.
+   Return factorial of the nonnegative integer *n*.
 
    .. versionchanged:: 3.10
       Floats with integral values (like ``5.0``) are no longer accepted.
index 4c2c8acd8f69d8bf4768d4ac3a28f0ccef4ba857..9df73b187bb827dfdf58748da568baa2014d81e5 100644 (file)
@@ -108,9 +108,7 @@ PyDoc_STRVAR(math_factorial__doc__,
 "factorial($module, n, /)\n"
 "--\n"
 "\n"
-"Find n!.\n"
-"\n"
-"Raise a ValueError if x is negative or non-integral.");
+"Find n!.");
 
 #define MATH_FACTORIAL_METHODDEF    \
     {"factorial", (PyCFunction)math_factorial, METH_O, math_factorial__doc__},
@@ -1112,4 +1110,4 @@ math_ulp(PyObject *module, PyObject *arg)
 exit:
     return return_value;
 }
-/*[clinic end generated code: output=634773bd18cd3f93 input=a9049054013a1b77]*/
+/*[clinic end generated code: output=77e7b8c161c39843 input=a9049054013a1b77]*/
index 11d9b7418a25a21f7696e8ea9bccf8aad92d1d96..40abd69f0a660072e41b8d5eca13f22fd2d8afe1 100644 (file)
@@ -2008,13 +2008,11 @@ math.factorial
     /
 
 Find n!.
-
-Raise a ValueError if x is negative or non-integral.
 [clinic start generated code]*/
 
 static PyObject *
 math_factorial(PyObject *module, PyObject *arg)
-/*[clinic end generated code: output=6686f26fae00e9ca input=713fb771677e8c31]*/
+/*[clinic end generated code: output=6686f26fae00e9ca input=366cc321df3d4773]*/
 {
     long x, two_valuation;
     int overflow;