]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iommu/apple-dart: Clear stream error indicator bits for T8110 DARTs
authorHector Martin <marcan@marcan.st>
Tue, 26 Aug 2025 10:57:18 +0000 (12:57 +0200)
committerJoerg Roedel <joerg.roedel@amd.com>
Fri, 5 Sep 2025 12:47:16 +0000 (14:47 +0200)
These registers exist and at least on the t602x variant the IRQ only
clears when theses are cleared.

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: Janne Grunau <j@jannau.net>
Reviewed-by: Sven Peter <sven@kernel.org>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Link: https://lore.kernel.org/r/20250826-dart-t8110-stream-error-v1-1-e33395112014@jannau.net
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/apple-dart.c

index 9696c8f143876416b10f812423aa5bd8986bfc88..95a4e62b8f63c34748f29549015fb3a006b23506 100644 (file)
 #define DART_T8110_ERROR_ADDR_LO 0x170
 #define DART_T8110_ERROR_ADDR_HI 0x174
 
+#define DART_T8110_ERROR_STREAMS 0x1c0
+
 #define DART_T8110_PROTECT 0x200
 #define DART_T8110_UNPROTECT 0x204
 #define DART_T8110_PROTECT_LOCK 0x208
@@ -1089,6 +1091,9 @@ static irqreturn_t apple_dart_t8110_irq(int irq, void *dev)
                error, stream_idx, error_code, fault_name, addr);
 
        writel(error, dart->regs + DART_T8110_ERROR);
+       for (int i = 0; i < BITS_TO_U32(dart->num_streams); i++)
+               writel(U32_MAX, dart->regs + DART_T8110_ERROR_STREAMS + 4 * i);
+
        return IRQ_HANDLED;
 }