]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Revert "test: temporary workaround for #21819"
authorFrantisek Sumsal <frantisek@sumsal.cz>
Fri, 11 Mar 2022 17:17:58 +0000 (18:17 +0100)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 25 Mar 2022 01:28:07 +0000 (10:28 +0900)
This reverts commit 95e35511bbdb7810c00c2e4a6cbda5b187192f74.

test/TEST-64-UDEV-STORAGE/test.sh

index c360c8b6610f6dd9844ce9eb65857469d6deee1d..04632952d002b9a7b12363394517439c14587a3c 100755 (executable)
@@ -119,6 +119,7 @@ test_run() {
 
     # Execute each currently defined function starting with "testcase_"
     for testcase in "${TESTCASES[@]}"; do
+        _image_cleanup
         echo "------ $testcase: BEGIN ------"
         # Note for my future frustrated self: `fun && xxx` (as well as ||, if, while,
         # until, etc.) _DISABLES_ the `set -e` behavior in _ALL_ nested function
@@ -129,14 +130,8 @@ test_run() {
         # So, be careful when adding clean up snippets in the testcase_*() functions -
         # if the `test_run_one()` function isn't the last command, you have propagate
         # the exit code correctly (e.g. `test_run_one() || return $?`, see below).
-
-        # FIXME: temporary workaround for intermittent fails in certain tests
-        # See: https://github.com/systemd/systemd/issues/21819
-        for ((_i = 0; _i < 3; _i++)); do
-            _image_cleanup
-            ec=0
-            "$testcase" "$test_id" && break || ec=$?
-        done
+        ec=0
+        "$testcase" "$test_id" || ec=$?
         case $ec in
             0)
                 passed+=("$testcase")