Backport last checkin:

SF #633013, Fix NIS causing interpreter core dump

Prevent the lengths passed to PyString_FromStringAndSize()
from being negative in some cases.

diff --git a/Modules/nismodule.c b/Modules/nismodule.c
index bcc8e9f968e9a8c9efdc74a9cbf37a0785dcb438..b9fe927613a99584028d2334527a9b6d67862cc0 100644 (file)
--- a/Modules/nismodule.c
+++ b/Modules/nismodule.c
@@ -85,8 +85,10 @@ nis_foreach (int instatus, char *inkey, int inkeylen, char *inval,
                int err;
 
                if (indata->fix) {
-                   inkeylen--;
-                   invallen--;
+                   if (inkeylen > 0 && inkey[inkeylen-1] == '\0')
+                       inkeylen--;
+                   if (invallen > 0 && inval[invallen-1] == '\0')
+                       invallen--;
                }
                key = PyString_FromStringAndSize(inkey, inkeylen);
                val = PyString_FromStringAndSize(inval, invallen);