]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[2160] add comment about Message vars in sync_udp_server
authorJelte Jansen <jelte@isc.org>
Wed, 5 Sep 2012 09:46:21 +0000 (11:46 +0200)
committerJelte Jansen <jelte@isc.org>
Wed, 5 Sep 2012 09:46:21 +0000 (11:46 +0200)
src/lib/asiodns/sync_udp_server.cc

index 037074a1c1cfa7cbfd5beee0449edc82ffdef9d7..0c577f2474aa902e34811feba5055be09652d6d7 100644 (file)
@@ -114,7 +114,12 @@ SyncUDPServer::handleRead(const asio::error_code& ec, const size_t length) {
         return;
     }
 
-    // Make sure the buffers are fresh
+    // Make sure the buffers are fresh.  Note that we don't touch query_
+    // because it's supposed to be cleared in lookup_callback_.  We should
+    // eventually even remove this member variable (and remove it from
+    // the lookup_callback_ interface, but until then, any callback
+    // implementation should be careful that it's the responsibility of
+    // the callback implementation.  See also #2239).
     output_buffer_->clear();
     answer_->clear(isc::dns::Message::RENDER);