]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
crypto: sun8i-ss - do not use sg_dma_len before calling DMA functions
authorCorentin Labbe <clabbe.montjoie@gmail.com>
Sun, 27 Apr 2025 11:12:36 +0000 (13:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jun 2025 10:04:01 +0000 (11:04 +0100)
[ Upstream commit 2dfc7cd74a5e062a5405560447517e7aab1c7341 ]

When testing sun8i-ss with multi_v7_defconfig, all CBC algorithm fail crypto
selftests.
This is strange since on sunxi_defconfig, everything was ok.
The problem was in the IV setup loop which never run because sg_dma_len
was 0.

Fixes: 359e893e8af4 ("crypto: sun8i-ss - rework handling of IV")
Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c

index 8a94f812e6d296390632ee0a937bfd4e8a302321..f8603b931b9bbbde230162c3dcdfd78898187f05 100644 (file)
@@ -117,7 +117,7 @@ static int sun8i_ss_setup_ivs(struct skcipher_request *areq)
 
        /* we need to copy all IVs from source in case DMA is bi-directionnal */
        while (sg && len) {
-               if (sg_dma_len(sg) == 0) {
+               if (sg->length == 0) {
                        sg = sg_next(sg);
                        continue;
                }