patch 8.2.0946: cannot use "q" to cancel a number prompt

Problem:    Cannot use "q" to cancel a number prompt.
Solution:   Recognize "q" instead of ignoring it.

diff --git a/src/misc1.c b/src/misc1.c
index a370a82f8d99e0908901a8c746796f76d06fcd8b..db76d9bfa86ed310a8e87b29b8dc96eeb122f581 100644 (file)
--- a/src/misc1.c
+++ b/src/misc1.c
@@ -945,7 +945,7 @@ get_number(
            do_redraw = FALSE;
            break;
        }
-       else if (c == CAR || c == NL || c == Ctrl_C || c == ESC)
+       else if (c == CAR || c == NL || c == Ctrl_C || c == ESC || c == 'q')
            break;
     }
     --no_mapping;
@@ -967,9 +967,9 @@ prompt_for_number(int *mouse_used)
 
     // When using ":silent" assume that <CR> was entered.
     if (mouse_used != NULL)
-       msg_puts(_("Type number and <Enter> or click with mouse (empty cancels): "));
+       msg_puts(_("Type number and <Enter> or click with the mouse (q or empty cancels): "));
     else
-       msg_puts(_("Type number and <Enter> (empty cancels): "));
+       msg_puts(_("Type number and <Enter> (q or empty cancels): "));
 
     // Set the state such that text can be selected/copied/pasted and we still
     // get mouse events. redraw_after_callback() will not redraw if cmdline_row

diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim
index 1de9c4c55619c8aec49809839dc8079ab57f878a..d3bf1db2509af4126ebc673a6d1b1994b6046bb0 100644 (file)
--- a/src/testdir/test_functions.vim
+++ b/src/testdir/test_functions.vim
@@ -1371,6 +1371,18 @@ func Test_inputlist()
   call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\<cr>3\<cr>", 'tx')
   call assert_equal(3, c)
 
+  " CR to cancel
+  call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\<cr>\<cr>", 'tx')
+  call assert_equal(0, c)
+
+  " Esc to cancel
+  call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\<cr>\<Esc>", 'tx')
+  call assert_equal(0, c)
+
+  " q to cancel
+  call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\<cr>q", 'tx')
+  call assert_equal(0, c)
+
   " Use backspace to delete characters in the prompt
   call feedkeys(":let c = inputlist(['Select color:', '1. red', '2. green', '3. blue'])\<cr>1\<BS>3\<BS>2\<cr>", 'tx')
   call assert_equal(2, c)

diff --git a/src/version.c b/src/version.c
index 30106ff003d2a18d8a772d86dfdd8f868e909a4e..bce00b3cb67ce2f7ccbd005bb24c6a9a5a5498a4 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -754,6 +754,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    946,
 /**/
     945,
 /**/