tests: ignore PIPE signal on TLS1.3-related tests

This was inadvertently omitted and that could cause unexpected
issues when one of the peers would close the connection earlier
than expected.

Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>

diff --git a/tests/tls13/change_cipher_spec.c b/tests/tls13/change_cipher_spec.c
index 23519d9fd4cdd41af08a77c64a2bfbd86076c34f..1a9b80c817dc124c9861e085ce29cdba49aa8958 100644 (file)
--- a/tests/tls13/change_cipher_spec.c
+++ b/tests/tls13/change_cipher_spec.c
@@ -309,6 +309,7 @@ void start(unsigned ccs_check)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/cookie.c b/tests/tls13/cookie.c
index 03d4f70ff4b3792d9b0c7274cc108138d5a3417d..562b9885f35f3a2ba2acf12db3d3326e8519a240 100644 (file)
--- a/tests/tls13/cookie.c
+++ b/tests/tls13/cookie.c
@@ -250,7 +250,7 @@ void doit(void)
        }
 
        if (child) {
-               int status;
+               int status = 0;
                /* parent */
                close(sockets[1]);
                server(sockets[0]);

diff --git a/tests/tls13/hello_random_value.c b/tests/tls13/hello_random_value.c
index e14b4e786ec8c8c109245fbac8c2b83295534fa9..b0ef0b23094c860cbaf38fc9324c155beb485074 100644 (file)
--- a/tests/tls13/hello_random_value.c
+++ b/tests/tls13/hello_random_value.c
@@ -248,7 +248,7 @@ void doit(void)
        }
 
        if (child) {
-               int status;
+               int status = 0;
                /* parent */
                close(sockets[1]);
                client(sockets[0]);

diff --git a/tests/tls13/key_share.c b/tests/tls13/key_share.c
index 205f7d0056ee49d2a208b73ccb61a7fcf778ee36..c848fe5a1562c85d78dc340c60e709a8a3b17b1d 100644 (file)
--- a/tests/tls13/key_share.c
+++ b/tests/tls13/key_share.c
@@ -258,7 +258,7 @@ static void server(int fd, gnutls_group_t exp_group, unsigned ngroups)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -271,6 +271,8 @@ static void start(const char *name, const char *prio, unsigned flag, gnutls_grou
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
+
        testname = name;
        success("== test %s ==\n", testname);
 

diff --git a/tests/tls13/no-psk-exts.c b/tests/tls13/no-psk-exts.c
index e8f1e2e84f8e31ac3ab130d21c0163841161d47d..c1c25fdf168b05ab07391b75740248bb1a424890 100644 (file)
--- a/tests/tls13/no-psk-exts.c
+++ b/tests/tls13/no-psk-exts.c
@@ -216,7 +216,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -229,6 +229,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/post-handshake-with-cert-ticket.c b/tests/tls13/post-handshake-with-cert-ticket.c
index 87b3ea4ea3080fa1bbaf7645be3ced6f2f232b9e..8ece3f1b4ccf8ba063af1effcc3e7a3e4131cf4d 100644 (file)
--- a/tests/tls13/post-handshake-with-cert-ticket.c
+++ b/tests/tls13/post-handshake-with-cert-ticket.c
@@ -318,7 +318,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;

diff --git a/tests/tls13/post-handshake-with-cert.c b/tests/tls13/post-handshake-with-cert.c
index 803a77b1960f5719080512dac83739ab14d7219a..d24e06db705dfc6b0f9e87b33d7f36cfea339fb8 100644 (file)
--- a/tests/tls13/post-handshake-with-cert.c
+++ b/tests/tls13/post-handshake-with-cert.c
@@ -327,7 +327,7 @@ static void server(int fd, int err, int type, unsigned max_auths)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;

diff --git a/tests/tls13/post-handshake-with-psk.c b/tests/tls13/post-handshake-with-psk.c
index d104d0d460d00a3cfa83f016b7b7c92089985cba..a85b57ab7526999b2157b52c94a320e645ed6740 100644 (file)
--- a/tests/tls13/post-handshake-with-psk.c
+++ b/tests/tls13/post-handshake-with-psk.c
@@ -311,7 +311,7 @@ static void server(int fd, int err, int type, unsigned max_auths)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;

diff --git a/tests/tls13/post-handshake-without-cert.c b/tests/tls13/post-handshake-without-cert.c
index 827fbc8495ef96cb994e8400884a80011962d68e..e6075ab0a0e6affdd3f8c1036a63036f16f449d1 100644 (file)
--- a/tests/tls13/post-handshake-without-cert.c
+++ b/tests/tls13/post-handshake-without-cert.c
@@ -219,7 +219,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -232,6 +232,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/prf.c b/tests/tls13/prf.c
index 22e7f0e08f5802dd34b77aae655b7dc9188ca204..da27332d4207340db31069979fed0d4beb67e86e 100644 (file)
--- a/tests/tls13/prf.c
+++ b/tests/tls13/prf.c
@@ -339,7 +339,7 @@ void doit(void)
        }
 
        if (child) {
-               int status;
+               int status = 0;
                /* parent */
 
                server(fd[0]);

diff --git a/tests/tls13/psk-dumbfw.c b/tests/tls13/psk-dumbfw.c
index c9c995801ebefff216fac4d7fc5aadd8a3ef2e4f..5d8ad8b1524d31344cac8f076f5002a4bbddf8ab 100644 (file)
--- a/tests/tls13/psk-dumbfw.c
+++ b/tests/tls13/psk-dumbfw.c
@@ -48,6 +48,7 @@ int main(int argc, char **argv)
 #include <unistd.h>
 #include <gnutls/gnutls.h>
 #include <assert.h>
+#include <signal.h>
 
 #include "tls13/ext-parse.h"
 
@@ -279,6 +280,15 @@ static void server(int sd, const char *prio)
                success("server: finished\n");
 }
 
+static void ch_handler(int sig)
+{
+       int status = 0;
+       wait(&status);
+       check_wait_status(status);
+       return;
+}
+
+
 static
 void run_test(const char *prio)
 {
@@ -286,6 +296,9 @@ void run_test(const char *prio)
        int err;
        int sockets[2];
 
+       signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
+
        success("trying with %s\n", prio);
 
        err = socketpair(AF_UNIX, SOCK_STREAM, 0, sockets);
@@ -303,7 +316,7 @@ void run_test(const char *prio)
        }
 
        if (child) {
-               int status;
+               int status = 0;
                /* parent */
                close(sockets[1]);
                server(sockets[0], prio);

diff --git a/tests/tls13/rnd-check-rollback-val.c b/tests/tls13/rnd-check-rollback-val.c
index 5971bdb2f6ac4201a115dafd38a90966f7c45925..f573596c5e1646b38f6dfb3cb595833985578d5f 100644 (file)
--- a/tests/tls13/rnd-check-rollback-val.c
+++ b/tests/tls13/rnd-check-rollback-val.c
@@ -210,7 +210,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -223,6 +223,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/rnd-rollback-detection.c b/tests/tls13/rnd-rollback-detection.c
index 7b136ea29a25cbcb862751839577768f93d95b31..0d1ef014985171201179be73edf9388736ef8f01 100644 (file)
--- a/tests/tls13/rnd-rollback-detection.c
+++ b/tests/tls13/rnd-rollback-detection.c
@@ -194,7 +194,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -207,6 +207,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/supported_versions.c b/tests/tls13/supported_versions.c
index bb9c7b6b929b9d05a6da1a392c59597302db685c..50ea986ca1ab51f4225c5ee03388e6f68743d014 100644 (file)
--- a/tests/tls13/supported_versions.c
+++ b/tests/tls13/supported_versions.c
@@ -314,7 +314,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -327,6 +327,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {

diff --git a/tests/tls13/tls12-no-tls13-exts.c b/tests/tls13/tls12-no-tls13-exts.c
index b7411fbdc8d3446b67ea8c8ea8e9cecdb194c8e4..ead25b4ad2eb9083612c0fdcb872c4e993f741c1 100644 (file)
--- a/tests/tls13/tls12-no-tls13-exts.c
+++ b/tests/tls13/tls12-no-tls13-exts.c
@@ -199,7 +199,7 @@ static void server(int fd)
 
 static void ch_handler(int sig)
 {
-       int status;
+       int status = 0;
        wait(&status);
        check_wait_status(status);
        return;
@@ -212,6 +212,7 @@ void doit(void)
        pid_t child;
 
        signal(SIGCHLD, ch_handler);
+       signal(SIGPIPE, SIG_IGN);
 
        ret = socketpair(AF_UNIX, SOCK_STREAM, 0, fd);
        if (ret < 0) {