]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
coredump: always log on failure in parse_core()
authorLuca Boccassi <luca.boccassi@microsoft.com>
Wed, 24 Nov 2021 20:13:44 +0000 (20:13 +0000)
committerLuca Boccassi <luca.boccassi@microsoft.com>
Tue, 30 Nov 2021 16:49:58 +0000 (16:49 +0000)
src/coredump/stacktrace.c

index dc8a71ac7c83707bc0781bbd18476aa5b3b0888b..b430f2b3eae16ba928e6738c1a3007cefbe40a8b 100644 (file)
@@ -367,12 +367,12 @@ static int parse_core(int fd, const char *executable, char **ret, JsonVariant **
         assert(fd >= 0);
 
         if (lseek(fd, 0, SEEK_SET) == (off_t) -1)
-                return -errno;
+                return log_warning_errno(errno, "Failed to seek to beginning of the core file: %m");
 
         if (ret) {
                 c.f = open_memstream_unlocked(&buf, &sz);
                 if (!c.f)
-                        return -ENOMEM;
+                        return log_oom();
         }
 
         elf_version(EV_CURRENT);