Fix a rare bug in rend_fn tests when the randomly generated port is 0

Since the rend code doesn't like the port to be 0, we shouldn't generate
the port by declaring crypto_rand_int(65536); instead we should
say crypto_rand_int(65535)+1.

Diagnosed by Matt Edman; fixes bug 1808.

diff --git a/src/test/test.c b/src/test/test.c
index 8f6564c486e518a2a7e901a11b7d1aa287385682..9948ecf9920ec66c82f1fa52b1d20ec6a18ecbd1 100644 (file)
--- a/src/test/test.c
+++ b/src/test/test.c
@@ -1029,7 +1029,7 @@ test_rend_fns(void)
                   intro->extend_info->identity_digest, DIGEST_LEN);
     /* Does not cover all IP addresses. */
     tor_addr_from_ipv4h(&intro->extend_info->addr, crypto_rand_int(65536));
-    intro->extend_info->port = crypto_rand_int(65536);
+    intro->extend_info->port = 1 + crypto_rand_int(65535);
     intro->intro_key = crypto_pk_dup_key(pk2);
     smartlist_add(generated->intro_nodes, intro);
   }