]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
auth: sasl-server - Drop auth_new mechanism functions that have become trivial
authorStephan Bosch <stephan.bosch@open-xchange.com>
Tue, 7 Mar 2023 15:24:26 +0000 (16:24 +0100)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Thu, 9 Oct 2025 08:41:22 +0000 (08:41 +0000)
src/auth/auth-sasl-mech-dovecot-token.c
src/auth/sasl-server-mech-anonymous.c
src/auth/sasl-server-mech-external.c
src/auth/sasl-server-mech-login.c
src/auth/sasl-server-mech-plain.c

index dcb39107bf1a114666a6ae92eb885f2168da3a52..7ccb00d26f391a90b35edcb93335d7c68ff8881d 100644 (file)
@@ -68,22 +68,12 @@ mech_dovecot_token_auth_continue(struct sasl_server_mech_request *request,
                safe_memset(auth_token, 0, strlen(auth_token));
 }
 
-static struct sasl_server_mech_request *mech_dovecot_token_auth_new(pool_t pool)
-{
-       struct sasl_server_mech_request *request;
-
-       request = p_new(pool, struct sasl_server_mech_request, 1);
-
-       return request;
-}
-
 const struct sasl_server_mech_def mech_dovecot_token = {
        .mech_name = "DOVECOT-TOKEN",
 
        .flags = SASL_MECH_SEC_PRIVATE | SASL_MECH_SEC_ALLOW_NULS,
        .passdb_need = SASL_MECH_PASSDB_NEED_NOTHING,
 
-       .auth_new = mech_dovecot_token_auth_new,
        .auth_initial = sasl_server_mech_generic_auth_initial,
        .auth_continue = mech_dovecot_token_auth_continue,
 };
index f357726238af22f1e391751381b4e559ff0a6d8d..df90103514b5283936fc893b49b15d80d19dcb75 100644 (file)
@@ -19,22 +19,12 @@ mech_anonymous_auth_continue(struct sasl_server_mech_request *request,
        sasl_server_request_success(request, "", 0);
 }
 
-static struct sasl_server_mech_request *mech_anonymous_auth_new(pool_t pool)
-{
-        struct sasl_server_mech_request *request;
-
-       request = p_new(pool, struct sasl_server_mech_request, 1);
-       request->pool = pool;
-       return request;
-}
-
 const struct sasl_server_mech_def mech_anonymous = {
        .mech_name = "ANONYMOUS",
 
        .flags = SASL_MECH_SEC_ANONYMOUS | SASL_MECH_SEC_ALLOW_NULS,
        .passdb_need = SASL_MECH_PASSDB_NEED_NOTHING,
 
-       .auth_new = mech_anonymous_auth_new,
        .auth_initial = sasl_server_mech_generic_auth_initial,
        .auth_continue = mech_anonymous_auth_continue,
 };
index 28d7792c31421c98fcaa65d0602b55f6b882386d..4cc3d457e6e73ba062d1765791adca00775789b8 100644 (file)
@@ -28,22 +28,12 @@ mech_external_auth_continue(struct sasl_server_mech_request *request,
                request, "", sasl_server_mech_plain_verify_callback);
 }
 
-static struct sasl_server_mech_request *mech_external_auth_new(pool_t pool)
-{
-       struct sasl_server_mech_request *request;
-
-       request = p_new(pool, struct sasl_server_mech_request, 1);
-
-       return request;
-}
-
 const struct sasl_server_mech_def mech_external = {
        .mech_name = "EXTERNAL",
 
        .flags = 0,
        .passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-       .auth_new = mech_external_auth_new,
        .auth_initial = sasl_server_mech_generic_auth_initial,
        .auth_continue = mech_external_auth_continue,
 };
index 9637387f6ad1b53585cbd21ff6cb116c948504f7..799ff73873176cffb1af10054594edf2f53af392 100644 (file)
@@ -51,22 +51,12 @@ mech_login_auth_initial(struct sasl_server_mech_request *request,
        }
 }
 
-static struct sasl_server_mech_request *mech_login_auth_new(pool_t pool)
-{
-       struct sasl_server_mech_request *request;
-
-       request = p_new(pool, struct sasl_server_mech_request, 1);
-
-       return request;
-}
-
 const struct sasl_server_mech_def mech_login = {
        .mech_name = "LOGIN",
 
        .flags = SASL_MECH_SEC_PLAINTEXT,
        .passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-       .auth_new = mech_login_auth_new,
        .auth_initial = mech_login_auth_initial,
        .auth_continue = mech_login_auth_continue,
 };
index bb1172d416d87d28d9e87df90b4631e9ffd31dad..c12c5bbee84c2538504cb7ae6013c6166c35c708 100644 (file)
@@ -62,22 +62,12 @@ mech_plain_auth_continue(struct sasl_server_mech_request *request,
                safe_memset(pass, 0, strlen(pass));
 }
 
-static struct sasl_server_mech_request *mech_plain_auth_new(pool_t pool)
-{
-       struct sasl_server_mech_request *request;
-
-       request = p_new(pool, struct sasl_server_mech_request, 1);
-
-       return request;
-}
-
 const struct sasl_server_mech_def mech_plain = {
        .mech_name = "PLAIN",
 
        .flags = SASL_MECH_SEC_PLAINTEXT | SASL_MECH_SEC_ALLOW_NULS,
        .passdb_need = SASL_MECH_PASSDB_NEED_VERIFY_PLAIN,
 
-       .auth_new = mech_plain_auth_new,
        .auth_initial = sasl_server_mech_generic_auth_initial,
        .auth_continue = mech_plain_auth_continue,
 };