Change X509_STORE_up_ref() shim return value

X509_STORE_up_ref() must return 1 on success, while the previous
implementation would return the references count. This commit fixes
that.

diff --git a/lib/isc/openssl_shim.c b/lib/isc/openssl_shim.c
index 1dcc921f01e5a5fb32b5c12a8c2c99e59971e492..3d6cbeed89320a03f695ea9fcc62b365607f52e7 100644 (file)
--- a/lib/isc/openssl_shim.c
+++ b/lib/isc/openssl_shim.c
@@ -174,7 +174,7 @@ OPENSSL_cleanup(void) {
 
 int
 X509_STORE_up_ref(X509_STORE *store) {
-       return (CRYPTO_add(&store->references, 1, CRYPTO_LOCK_X509_STORE));
+       return (CRYPTO_add(&store->references, 1, CRYPTO_LOCK_X509_STORE) > 0);
 }
 
 #endif /* !HAVE_OPENSSL_CLEANUP */