]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rtw89: Fix TX fail with A2DP after scanning
authorPo-Hao Huang <phhuang@realtek.com>
Mon, 21 Oct 2024 06:32:19 +0000 (14:32 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Fri, 25 Oct 2024 02:24:38 +0000 (10:24 +0800)
There might be some racing between BT and WiFi after scan. Since
one of the TX related register will be modified by both FW and
rtw89_set_channel() in driver, which could cause Tx fail. Reorder
the calling sequence to only notify coexistence mechanism after
rtw89_set_channel() is called, so that there are no concurrent
operations.

Fixes: 5f499ce69b8d ("wifi: rtw89: pause/proceed MCC for ROC and HW scan")
Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241021063219.22613-1-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/fw.c

index 5f160486474e471db681d000009bf7bd749b912e..f504d1681fa341ec9791367b7c904ce5e869109b 100644 (file)
@@ -6721,6 +6721,8 @@ void rtw89_hw_scan_complete(struct rtw89_dev *rtwdev,
        if (!rtwvif_link)
                return;
 
+       rtw89_chanctx_proceed(rtwdev);
+
        rtwvif = rtwvif_link->rtwvif;
 
        reg = rtw89_mac_reg_by_idx(rtwdev, mac->rx_fltr, rtwvif_link->mac_idx);
@@ -6738,8 +6740,6 @@ void rtw89_hw_scan_complete(struct rtw89_dev *rtwdev,
        scan_info->last_chan_idx = 0;
        scan_info->scanning_vif = NULL;
        scan_info->abort = false;
-
-       rtw89_chanctx_proceed(rtwdev);
 }
 
 void rtw89_hw_scan_abort(struct rtw89_dev *rtwdev,