soc: mediatek: mtk-svs: fix device leaks on mt8192 probe failure

Make sure to drop the references taken by of_find_device_by_node() when
looking up the thermal sensor and opp devices during probe on probe
failure (e.g. probe deferral) and on driver unbind.

Fixes: 0bbb09b2af9d ("soc: mediatek: SVS: add mt8192 SVS GPU driver")
Cc: Roger Lu <roger.lu@mediatek.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20250909095651.5530-3-johan@kernel.org
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 48804e1e5a6c81f4fd1d43442c66ea0d671abc0a..f45537546553ecf44ea1f208f9e80342fb7fa33d 100644 (file)
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2176,6 +2176,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
 {
        struct device *dev;
        u32 idx;
+       int ret;
 
        svsp->rst = devm_reset_control_get_optional(svsp->dev, "svs_rst");
        if (IS_ERR(svsp->rst))
@@ -2186,6 +2187,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
        if (IS_ERR(dev))
                return dev_err_probe(svsp->dev, PTR_ERR(dev),
                                     "failed to get lvts device\n");
+       put_device(dev);
 
        for (idx = 0; idx < svsp->bank_max; idx++) {
                struct svs_bank *svsb = &svsp->banks[idx];
@@ -2195,6 +2197,7 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
                case SVSB_SWID_CPU_LITTLE:
                case SVSB_SWID_CPU_BIG:
                        svsb->opp_dev = get_cpu_device(bdata->cpu_id);
+                       get_device(svsb->opp_dev);
                        break;
                case SVSB_SWID_CCI:
                        svsb->opp_dev = svs_add_device_link(svsp, "cci");
@@ -2214,6 +2217,11 @@ static int svs_mt8192_platform_probe(struct svs_platform *svsp)
                        return dev_err_probe(svsp->dev, PTR_ERR(svsb->opp_dev),
                                             "failed to get OPP device for bank %d\n",
                                             idx);
+
+               ret = devm_add_action_or_reset(svsp->dev, svs_put_device,
+                                              svsb->opp_dev);
+               if (ret)
+                       return ret;
        }
 
        return 0;