]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: st_lsm6dsx: Replace scnprintf() with sysfs_emit()
authorAkshay Bansod <akbansd@gmail.com>
Mon, 11 Aug 2025 16:56:40 +0000 (22:26 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 16 Aug 2025 13:33:58 +0000 (14:33 +0100)
Update the sysfs interface for sampling frequency and scale attributes.
Replace `scnprintf()` with `sysfs_emit_at()` which is PAGE_SIZE-aware
and recommended for use in sysfs.

Signed-off-by: Akshay Bansod <akbansd@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Link: https://patch.msgid.link/20250811165641.1214347-1-akbansd@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c

index c65ad49829e7da3716825626d9cd25fdfae32ac0..d8cb4b0218d53002caf35b3fc775049208a7018e 100644 (file)
@@ -2035,10 +2035,10 @@ st_lsm6dsx_sysfs_sampling_frequency_avail(struct device *dev,
 
        odr_table = &sensor->hw->settings->odr_table[sensor->id];
        for (i = 0; i < odr_table->odr_len; i++)
-               len += scnprintf(buf + len, PAGE_SIZE - len, "%d.%03d ",
-                                odr_table->odr_avl[i].milli_hz / 1000,
-                                odr_table->odr_avl[i].milli_hz % 1000);
-       buf[len - 1] = '\n';
+            len += sysfs_emit_at(buf, len, "%d.%03d%c",
+                                 odr_table->odr_avl[i].milli_hz / 1000,
+                                 odr_table->odr_avl[i].milli_hz % 1000,
+                                 (i == odr_table->odr_len - 1) ? '\n' : ' ');
 
        return len;
 }
@@ -2054,9 +2054,9 @@ static ssize_t st_lsm6dsx_sysfs_scale_avail(struct device *dev,
 
        fs_table = &hw->settings->fs_table[sensor->id];
        for (i = 0; i < fs_table->fs_len; i++)
-               len += scnprintf(buf + len, PAGE_SIZE - len, "0.%09u ",
-                                fs_table->fs_avl[i].gain);
-       buf[len - 1] = '\n';
+            len += sysfs_emit_at(buf, len, "0.%09u%c",
+                                 fs_table->fs_avl[i].gain,
+                                 (i == fs_table->fs_len - 1) ? '\n' : ' ');
 
        return len;
 }