- do not override passwd after getpwuid_r et.al. calls

diff --git a/package/snapper.changes b/package/snapper.changes
index e31c2b2f31f9fa923f761d562f89af68b4672b42..c3c7a82322fd7412b3d61b6dc849895521c1364e 100644 (file)
--- a/package/snapper.changes
+++ b/package/snapper.changes
@@ -1,3 +1,9 @@
+-------------------------------------------------------------------
+Tue Nov 24 11:58:44 CET 2020 - aschnell@suse.com
+
+- do not override passwd after getpwuid_r et.al. calls
+  (gh#openSUSE/snapper#589)
+
 -------------------------------------------------------------------
 Thu Nov 19 11:49:29 CET 2020 - aschnell@suse.com
 

diff --git a/pam/pam_snapper.c b/pam/pam_snapper.c
index 9c581fe9b02d5930f3c024a0602f74fba0a7f8cd..7ff55f63b78b56a17362ce764ae16817fcf5634c 100644 (file)
--- a/pam/pam_snapper.c
+++ b/pam/pam_snapper.c
@@ -528,8 +528,6 @@ static int get_ugid( pam_handle_t * pamh, const char *pam_user, uid_t * uid, gid
                return -1;
        }
 
-       memset( pwd.pw_passwd, 0, strlen( pwd.pw_passwd ) );
-
        *uid = pwd.pw_uid;
        *gid = pwd.pw_gid;
 

diff --git a/snapper/AppUtil.cc b/snapper/AppUtil.cc
index 54a4403479956e281d1f7da72340e1b876321d4e..1de88ac851be3db382096f52a128953fde93567b 100644 (file)
--- a/snapper/AppUtil.cc
+++ b/snapper/AppUtil.cc
@@ -315,8 +315,6 @@ namespace snapper
        if (e != 0 || result == NULL)
            return false;
 
-       memset(pwd.pw_passwd, 0, strlen(pwd.pw_passwd));
-
        username = pwd.pw_name;
        gid = pwd.pw_gid;
 
@@ -339,8 +337,6 @@ namespace snapper
        if (e != 0 || result == NULL)
            return false;
 
-       memset(pwd.pw_passwd, 0, strlen(pwd.pw_passwd));
-
        dir = pwd.pw_dir;
 
        return true;
@@ -365,8 +361,6 @@ namespace snapper
            return false;
        }
 
-       memset(pwd.pw_passwd, 0, strlen(pwd.pw_passwd));
-
        uid = pwd.pw_uid;
 
        return true;
@@ -391,8 +385,6 @@ namespace snapper
            return false;
        }
 
-       memset(grp.gr_passwd, 0, strlen(grp.gr_passwd));
-
        gid = grp.gr_gid;
 
        return true;