]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: fix memory leak in error path 18763/head
authorLennart Poettering <lennart@poettering.net>
Tue, 23 Feb 2021 14:43:19 +0000 (15:43 +0100)
committerLennart Poettering <lennart@poettering.net>
Tue, 23 Feb 2021 14:45:26 +0000 (15:45 +0100)
Coverity 1431998

src/core/execute.c

index d27adbbba54277282fd755609ae0c6e354baa023..e5c80fb183a8814bd46735fe66ca231cd4eb1fd0 100644 (file)
@@ -3202,11 +3202,16 @@ static int apply_mount_namespace(
 
         if (MANAGER_IS_SYSTEM(u->manager)) {
                 propagate_dir = path_join("/run/systemd/propagate/", u->id);
-                if (!propagate_dir)
-                        return -ENOMEM;
+                if (!propagate_dir) {
+                        r = -ENOMEM;
+                        goto finalize;
+                }
+
                 incoming_dir = strdup("/run/systemd/incoming");
-                if (!incoming_dir)
-                        return -ENOMEM;
+                if (!incoming_dir) {
+                        r = -ENOMEM;
+                        goto finalize;
+                }
         }
 
         r = setup_namespace(root_dir, root_image, context->root_image_options,