Fix a crash bug on SETCIRCUITPURPOSE.

diff --git a/changes/bug5796 b/changes/bug5796
new file mode 100644 (file)
index 0000000..b92659f
--- /dev/null
+++ b/changes/bug5796
@@ -0,0 +1,4 @@
+  o Minor bugfixes (controller):
+    - Fix a NULL-pointer derefernce on a badly formed
+      SETCIRCUITPURPOSE command. Found by mikeyc. Fixes bug 5796;
+      bugfix on 0.2.2.9-alpha.

diff --git a/src/or/control.c b/src/or/control.c
index ddfc80e8fd7a3a02941496e9a9f891b0cd1b7c93..b41b291061881ee60102335220d66fc2082c10fa 100644 (file)
--- a/src/or/control.c
+++ b/src/or/control.c
@@ -2389,6 +2389,10 @@ handle_control_setcircuitpurpose(control_connection_t *conn,
 
   {
     const char *purp = find_element_starting_with(args,1,"PURPOSE=");
+    if (!purp) {
+      connection_write_str_to_buf("552 No purpose given\r\n", conn);
+      goto done;
+    }
     new_purpose = circuit_purpose_from_string(purp);
     if (new_purpose == CIRCUIT_PURPOSE_UNKNOWN) {
       connection_printf_to_buf(conn, "552 Unknown purpose \"%s\"\r\n", purp);