2004-12-18 Havoc Pennington <hp@redhat.com>

	* dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
	macro

	* dbus/dbus-message.c: fix a comment, and add a still-unused
	not-implemented function

	* dbus/dbus-marshal.h: fix comment

	* dbus/dbus-internals.h (_DBUS_ISASCII): new macro

diff --git a/ChangeLog b/ChangeLog
index 4783db899e56389dec94f8c761f978d79602fac6..dfe5c6cdd9e26bdd101ed4a0b305ecbb13f51659 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2004-12-18  Havoc Pennington  <hp@redhat.com>
+
+       * dbus/dbus-string.c (_dbus_string_validate_ascii): use ISASCII
+       macro
+
+       * dbus/dbus-message.c: fix a comment, and add a still-unused
+       not-implemented function
+
+       * dbus/dbus-marshal.h: fix comment
+
+       * dbus/dbus-internals.h (_DBUS_ISASCII): new macro
+
 2004-12-17  Joe Shaw  <joeshaw@novell.com>
 
        * mono/DBusType/Byte.cs, mono/DBusType/Int32.cs,

diff --git a/dbus/dbus-internals.h b/dbus/dbus-internals.h
index 7e3c458fd24ec3d11a72f022511017ee226ed709..8560d4ec5f49936a78bd3f543b2bb366d71b5bd3 100644 (file)
--- a/dbus/dbus-internals.h
+++ b/dbus/dbus-internals.h
@@ -198,6 +198,8 @@ char**      _dbus_dup_string_array      (const char **array);
 #undef ABS
 #define ABS(a)    (((a) < 0) ? -(a) : (a))
 
+#define _DBUS_ISASCII(c) ((c) != '\0' && (((c) & ~0x7f) == 0))
+
 typedef void (* DBusForeachFunction) (void *element,
                                       void *data);
 

diff --git a/dbus/dbus-marshal.h b/dbus/dbus-marshal.h
index 0a34920f96d8d7348489d2ab6fa9ffee56c9b0a2..dccfc1db30f5b9ddf9e8e3b25ea261b4fb7e6939 100644 (file)
--- a/dbus/dbus-marshal.h
+++ b/dbus/dbus-marshal.h
@@ -345,4 +345,4 @@ dbus_bool_t _dbus_marshal_validate_arg    (const DBusString *str,
 
 dbus_bool_t _dbus_type_is_valid           (int               typecode);
 
-#endif /* DBUS_PROTOCOL_H */
+#endif /* DBUS_MARSHAL_H */

diff --git a/dbus/dbus-message.c b/dbus/dbus-message.c
index df1c789a75af88d09d765b3f691925ca36c26710..143ac96ac483d0b7c12e7eebaf852bc7a5529146 100644 (file)
--- a/dbus/dbus-message.c
+++ b/dbus/dbus-message.c
@@ -2323,6 +2323,21 @@ dbus_message_append_args (DBusMessage *message,
   va_end (var_args);
 
   return retval;
+}
+
+/* Swap into our byte order if message isn't already.
+ * Done only when required, which allows the bus to avoid
+ * ever doing this as it routes messages.
+ */
+static void
+_dbus_message_ensure_our_byte_order (DBusMessage *message)
+{
+  if (message->byte_order == DBUS_COMPILER_BYTE_ORDER)
+    return;
+
+  
+
+
 }
 
 /**
@@ -5188,7 +5203,8 @@ decode_string_field (const DBusString   *data,
 /* FIXME because the service/interface/member/error names are already
  * validated to be in the particular ASCII subset, UTF-8 validating
  * them could be skipped as a probably-interesting optimization.
- * The UTF-8 validation definitely shows up in profiles.
+ * The UTF-8 validation shows up in callgrind-type profiles but
+ * not so much in sample/time-based profiles.
  */
 static dbus_bool_t
 decode_header_data (const DBusString   *data,

diff --git a/dbus/dbus-string.c b/dbus/dbus-string.c
index 627fbb064469ca34c6e0fee44ae3e74a7a01ac48..1188c6cbd97b6445a1f23f5f884a4300518a7ab6 100644 (file)
--- a/dbus/dbus-string.c
+++ b/dbus/dbus-string.c
@@ -2394,8 +2394,7 @@ _dbus_string_validate_ascii (const DBusString *str,
   end = s + len;
   while (s != end)
     {
-      if (_DBUS_UNLIKELY (*s == '\0' ||
-                          ((*s & ~0x7f) != 0)))
+      if (_DBUS_UNLIKELY (!_DBUS_ISASCII (*s)))
         return FALSE;
         
       ++s;