]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
PCI: microchip: Correct the DED and SEC interrupt bit offsets
authorDaire McNamara <daire.mcnamara@microchip.com>
Fri, 28 Jul 2023 13:13:55 +0000 (14:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:42:46 +0000 (09:42 +0200)
[ Upstream commit 6d473a5a26136edf55c435a1c433e52910e03926 ]

The SEC and DED interrupt bits are laid out the wrong way round so the SEC
interrupt handler attempts to mask, unmask, and clear the DED interrupt
and vice versa. Correct the bit offsets so that each interrupt handler
operates properly.

Link: https://lore.kernel.org/r/20230728131401.1615724-2-daire.mcnamara@microchip.com
Fixes: 6f15a9c9f941 ("PCI: microchip: Add Microchip PolarFire PCIe controller driver")
Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pci/controller/pcie-microchip-host.c

index 7263d175b5adb7338ac77034aa1e5e1dea2856a4..5ba101efd9326b123d04f4b0c9aae392930feeb6 100644 (file)
 #define EVENT_PCIE_DLUP_EXIT                   2
 #define EVENT_SEC_TX_RAM_SEC_ERR               3
 #define EVENT_SEC_RX_RAM_SEC_ERR               4
-#define EVENT_SEC_AXI2PCIE_RAM_SEC_ERR         5
-#define EVENT_SEC_PCIE2AXI_RAM_SEC_ERR         6
+#define EVENT_SEC_PCIE2AXI_RAM_SEC_ERR         5
+#define EVENT_SEC_AXI2PCIE_RAM_SEC_ERR         6
 #define EVENT_DED_TX_RAM_DED_ERR               7
 #define EVENT_DED_RX_RAM_DED_ERR               8
-#define EVENT_DED_AXI2PCIE_RAM_DED_ERR         9
-#define EVENT_DED_PCIE2AXI_RAM_DED_ERR         10
+#define EVENT_DED_PCIE2AXI_RAM_DED_ERR         9
+#define EVENT_DED_AXI2PCIE_RAM_DED_ERR         10
 #define EVENT_LOCAL_DMA_END_ENGINE_0           11
 #define EVENT_LOCAL_DMA_END_ENGINE_1           12
 #define EVENT_LOCAL_DMA_ERROR_ENGINE_0         13