]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-journal: use TAKE_PTR() a bit more
authorFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 23 May 2023 17:21:20 +0000 (19:21 +0200)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 24 May 2023 11:55:39 +0000 (13:55 +0200)
src/libsystemd/sd-journal/catalog.c
src/resolve/resolved-dns-rr.c

index 78f7f226c893247c1214082cea4c786a5c44460c..7f1dc0b4ed7c76e131e0556e734d3cbdc8dc31d8 100644 (file)
@@ -171,7 +171,8 @@ static int finish_item(
 
                 if (ordered_hashmap_update(h, i, combined) < 0)
                         return log_oom();
-                combined = NULL;
+
+                TAKE_PTR(combined);
                 free(prev);
         } else {
                 /* A new item */
@@ -181,8 +182,9 @@ static int finish_item(
 
                 if (ordered_hashmap_put(h, i, combined) < 0)
                         return log_oom();
-                i = NULL;
-                combined = NULL;
+
+                TAKE_PTR(i);
+                TAKE_PTR(combined);
         }
 
         return 0;
index d3175b1b9de30c265ae23c520b344f8545e11a0b..78739d588d477b0e7ac5b725d44485d8f29c503e 100644 (file)
@@ -1229,12 +1229,11 @@ int dns_resource_record_to_wire_format(DnsResourceRecord *rr, bool canonical) {
         assert(packet._data);
 
         free(rr->wire_format);
-        rr->wire_format = packet._data;
+        rr->wire_format = TAKE_PTR(packet._data);
         rr->wire_format_size = packet.size;
         rr->wire_format_rdata_offset = rds;
         rr->wire_format_canonical = canonical;
 
-        packet._data = NULL;
         dns_packet_unref(&packet);
 
         return 0;