Pass precision value to mssql.DATETIME2 when it is 0

The simple check on the precision results in DATETIME2(0) generating a
DATETIME2 column, with default precision, which is 7.

(cherry picked from commit 80ce23f6fd0f14ab656d3ec82773bd0cffbd4791)

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index da8bbbd5f61564f133a2f1cf1658cf5b2e994304..3a81861bb330a8ae4378c0e8aa928f4168b3158c 100644 (file)
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -788,7 +788,7 @@ class MSTypeCompiler(compiler.GenericTypeCompiler):
 
     def visit_DATETIME2(self, type_, **kw):
         precision = getattr(type_, 'precision', None)
-        if precision:
+        if precision is not None:
             return "DATETIME2(%s)" % precision
         else:
             return "DATETIME2"

diff --git a/test/dialect/mssql/test_types.py b/test/dialect/mssql/test_types.py
index 17ceb6b61a72267d217b6888ab211e93bf981889..e5462eb79a28d5a56acbbd5a56973bfac26bd629 100644 (file)
--- a/test/dialect/mssql/test_types.py
+++ b/test/dialect/mssql/test_types.py
@@ -466,6 +466,8 @@ class TypeRoundTripTest(
 
             (mssql.MSDateTime2, [], {},
              'DATETIME2', ['>=', (10,)]),
+            (mssql.MSDateTime2, [0], {},
+             'DATETIME2(0)', ['>=', (10,)]),
             (mssql.MSDateTime2, [1], {},
              'DATETIME2(1)', ['>=', (10,)]),