]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd: Remove comment about handling errors in amdgpu_device_ip_suspend_phase1()
authorMario Limonciello <mario.limonciello@amd.com>
Thu, 2 Oct 2025 17:42:41 +0000 (12:42 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 13 Oct 2025 18:14:34 +0000 (14:14 -0400)
Error handling was introduced in commit e095026f0066 ("drm/amdgpu:
validate suspend before function call") so the comment about TODO is no
longer needed.

Fixes: e095026f0066 ("drm/amdgpu: validate suspend before function call")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

index edd086213049bb34e97fc34450e53bc32c891b45..3c1d784d6f3bb4047418f178f2380b5d396d68c1 100644 (file)
@@ -3780,7 +3780,6 @@ static int amdgpu_device_ip_suspend_phase1(struct amdgpu_device *adev)
                if (adev->ip_blocks[i].version->type != AMD_IP_BLOCK_TYPE_DCE)
                        continue;
 
-               /* XXX handle errors */
                r = amdgpu_ip_block_suspend(&adev->ip_blocks[i]);
                if (r)
                        return r;