]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
qtnfmac: drop error reports for out-of-bounds key indexes
authorSergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Fri, 5 Oct 2018 10:11:40 +0000 (10:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 24 Nov 2019 07:23:10 +0000 (08:23 +0100)
[ Upstream commit 35da3fe63b8647ce3cc52fccdf186a60710815fb ]

On disconnect wireless core attempts to remove all the supported keys.
Following cfg80211_ops conventions, firmware returns -ENOENT code
for the out-of-bound key indexes. This is a normal behavior,
so no need to report errors for this case.

Signed-off-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c

index a450bc6bc77453b368aecef35b19971241e8994b..d02f68792ce41145f6f5f99cd5d2373ad1eb6e56 100644 (file)
@@ -509,9 +509,16 @@ static int qtnf_del_key(struct wiphy *wiphy, struct net_device *dev,
        int ret;
 
        ret = qtnf_cmd_send_del_key(vif, key_index, pairwise, mac_addr);
-       if (ret)
-               pr_err("VIF%u.%u: failed to delete key: idx=%u pw=%u\n",
-                      vif->mac->macid, vif->vifid, key_index, pairwise);
+       if (ret) {
+               if (ret == -ENOENT) {
+                       pr_debug("VIF%u.%u: key index %d out of bounds\n",
+                                vif->mac->macid, vif->vifid, key_index);
+               } else {
+                       pr_err("VIF%u.%u: failed to delete key: idx=%u pw=%u\n",
+                              vif->mac->macid, vif->vifid,
+                              key_index, pairwise);
+               }
+       }
 
        return ret;
 }