]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: hym8563: fix incorrect maximum clock rate handling
authorBrian Masney <bmasney@redhat.com>
Thu, 10 Jul 2025 15:20:22 +0000 (11:20 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:22:35 +0000 (16:22 +0200)
[ Upstream commit d0a518eb0a692a2ab8357e844970660c5ea37720 ]

When hym8563_clkout_round_rate() is called with a requested rate higher
than the highest supported rate, it currently returns 0, which disables
the clock. According to the clk API, round_rate() should instead return
the highest supported rate. Update the function to return the maximum
supported rate in this case.

Fixes: dcaf038493525 ("rtc: add hym8563 rtc-driver")
Signed-off-by: Brian Masney <bmasney@redhat.com>
Link: https://lore.kernel.org/r/20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-hym8563.c

index 0fb79c4afb4639a27f83c67bba62529fb745f40d..b5e76d6ee64beab8859b9d5d6df5ff4142625cd5 100644 (file)
@@ -312,7 +312,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rate,
                if (clkout_rates[i] <= rate)
                        return clkout_rates[i];
 
-       return 0;
+       return clkout_rates[0];
 }
 
 static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate,