sspi: Return CURLE_LOGIN_DENIED on AcquireCredentialsHandle() failure

Return a more appropriate error, rather than CURLE_OUT_OF_MEMORY when
acquiring the credentials handle fails. This is then consistent with
the code prior to commit f7e24683c4 when log-in credentials were empty.

diff --git a/lib/curl_ntlm_msgs.c b/lib/curl_ntlm_msgs.c
index 92211aa97f741615f118c69d63aa25ceec584e71..14ddc5f9ce278cde2264573428bc0b2c9363f9c7 100644 (file)
--- a/lib/curl_ntlm_msgs.c
+++ b/lib/curl_ntlm_msgs.c
@@ -477,7 +477,7 @@ CURLcode Curl_ntlm_create_type1_message(const char *userp,
                                               ntlm->p_identity, NULL, NULL,
                                               ntlm->credentials, &expiry);
   if(status != SEC_E_OK)
-    return CURLE_OUT_OF_MEMORY;
+    return CURLE_LOGIN_DENIED;
 
   /* Allocate our new context handle */
   ntlm->context = malloc(sizeof(CtxtHandle));

diff --git a/lib/curl_sasl_sspi.c b/lib/curl_sasl_sspi.c
index 9aa84d77fe8ec18b34ad9c11623d251b9b7f162b..21edcd65dc054395137d490751492f434362d033 100644 (file)
--- a/lib/curl_sasl_sspi.c
+++ b/lib/curl_sasl_sspi.c
@@ -210,7 +210,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
     Curl_safefree(resp);
     Curl_safefree(chlg);
 
-    return CURLE_OUT_OF_MEMORY;
+    return CURLE_LOGIN_DENIED;
   }
 
   /* Setup the challenge "input" security buffer */
@@ -367,7 +367,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
                                                 krb5->p_identity, NULL, NULL,
                                                 krb5->credentials, &expiry);
     if(status != SEC_E_OK)
-      return CURLE_OUT_OF_MEMORY;
+      return CURLE_LOGIN_DENIED;
 
     /* Allocate our new context handle */
     krb5->context = malloc(sizeof(CtxtHandle));