]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Minor improvements to the convolve() recipe (GH-24012)
authorRaymond Hettinger <rhettinger@users.noreply.github.com>
Wed, 30 Dec 2020 20:51:19 +0000 (12:51 -0800)
committerGitHub <noreply@github.com>
Wed, 30 Dec 2020 20:51:19 +0000 (12:51 -0800)
* Minor improvement to speed and space efficiency for the convolve() recipe
* Don't require convolve's kernel to be a sequence.

Doc/library/itertools.rst

index 03416a0a7fbcb8c1fa07da6a3770431d91d9269b..fd77f99a88f577e538594ad505d4d10e5554dad6 100644 (file)
@@ -791,9 +791,9 @@ which incur interpreter overhead.
        # convolve(data, [0.25, 0.25, 0.25, 0.25]) --> Moving average (blur)
        # convolve(data, [1, -1]) --> 1st finite difference (1st derivative)
        # convolve(data, [1, -2, 1]) --> 2nd finite difference (2nd derivative)
-       kernel = list(reversed(kernel))
+       kernel = tuple(kernel)[::-1]
        n = len(kernel)
-       window = collections.deque([0] * n, maxlen=n)
+       window = collections.deque([0], maxlen=n) * n
        for x in chain(signal, repeat(0, n-1)):
            window.append(x)
            yield sum(map(operator.mul, kernel, window))