spi: spi-zynqmp-gqspi: Fix missing unlock on error in zynqmp_qspi_exec_op()

[ Upstream commit 6043357263fbe2df0bf0736d971ad5dce7d19dc1 ]

Add the missing unlock before return from function zynqmp_qspi_exec_op()
in the error handling case.

Fixes: a0f65be6e880 ("spi: spi-zynqmp-gqspi: add mutex locking for exec_op")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210412160025.194171-1-weiyongjun1@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
index 036d8ae41c0620f35ce6978a02c5b036953e2312..408e348382c5c1a25aae6dc96bfd0dff26d02506 100644 (file)
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -965,8 +965,10 @@ static int zynqmp_qspi_exec_op(struct spi_mem *mem,
 
        if (op->cmd.opcode) {
                tmpbuf = kzalloc(op->cmd.nbytes, GFP_KERNEL | GFP_DMA);
-               if (!tmpbuf)
+               if (!tmpbuf) {
+                       mutex_unlock(&xqspi->op_lock);
                        return -ENOMEM;
+               }
                tmpbuf[0] = op->cmd.opcode;
                reinit_completion(&xqspi->data_completion);
                xqspi->txbuf = tmpbuf;