]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
librpc/idl:condtional_ace: shift CONDITIONAL_ACE_FLAG_TOKEN_FROM_ATTR to last bit
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 10 Nov 2023 01:31:59 +0000 (14:31 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 27 Nov 2023 22:37:31 +0000 (22:37 +0000)
This region is "available for application-specific data" in the
CLAIM_SECURITY_ATTRIBUTE_ space, according to [MS-DTYP] 2.4.10.1,
so it nicer to use that, even though we are not actually setting the
flag on the V1 claims.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
librpc/idl/conditional_ace.idl
librpc/idl/security.idl

index 783336cbc658a6fd87bf8e2a38e11f363a2fe84b..55ec367144482d7255b4dab5ff44cd90721e5f1d 100644 (file)
@@ -415,7 +415,7 @@ interface conditional_ace
         * operator that argument has been resolved into an ordinary
         * token. So we set the flag so the operator can know.
         */
-       const uint32 CONDITIONAL_ACE_FLAG_TOKEN_FROM_ATTR = 0x8000;
+       const uint32 CONDITIONAL_ACE_FLAG_TOKEN_FROM_ATTR = 1 << 31;
 
        /*
         * The maximum size of the conditional ACE conditions in the
index 202372909579d66b759712dddbb4c6d6481a3808..400da6b3355d66b4f331b350fe7b05e7376c996f 100644 (file)
@@ -618,12 +618,12 @@ interface security
                CLAIM_SECURITY_ATTRIBUTE_MANDATORY         = 0x20,
                /*
                 * Conditional ACEs use some of the above flags in
-                * combination with an internal one at the other end
-                * of a 16 bit field (defined in conditional_ace.idl).
+                * combination with an internal one defined in
+                * conditional_ace.idl.
                 * This next definition is warning us in case a clash
                 * develops (which seems very unlikely).
                 */
-               CLAIM_SECURITY_ATTRIBUTE_RESERVED_FOR_SAMBA = 0x8000
+               CLAIM_SECURITY_ATTRIBUTE_RESERVED_FOR_SAMBA   = 1UL << 31
        } claim_flags;
 
        /*