]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
VFX: vxfs: Fixup some warnings
authorNoel Power <noel.power@suse.com>
Wed, 9 Jun 2021 13:58:41 +0000 (14:58 +0100)
committerNoel Power <npower@samba.org>
Fri, 11 Jun 2021 09:30:53 +0000 (09:30 +0000)
../../source3/modules/vfs_vxfs.c:343:6: error: unused variable ‘i’ [-Werror=unused-variable]
  int i, offset = 0;
      ^
../../source3/modules/vfs_vxfs.c:342:17: error: unused variable ‘n_id’ [-Werror=unused-variable]
  uint32_t e_id, n_id;
                 ^~~~
../../source3/modules/vfs_vxfs.c:342:11: error: unused variable ‘e_id’ [-Werror=unused-variable]
  uint32_t e_id, n_id;
           ^~~~
../../source3/modules/vfs_vxfs.c:341:35: error: unused variable ‘n_perm’ [-Werror=unused-variable]
  uint16_t e_type, n_type, e_perm, n_perm;
                                   ^~~~~~
../../source3/modules/vfs_vxfs.c:341:27: error: unused variable ‘e_perm’ [-Werror=unused-variable]
  uint16_t e_type, n_type, e_perm, n_perm;
                           ^~~~~~
../../source3/modules/vfs_vxfs.c: In function ‘vxfs_compare’:
../../source3/modules/vfs_vxfs.c:407:6: error: unused variable ‘i’ [-Werror=unused-variable]
  int i, count = 0;
      ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_vxfs.c

index 9e663aef7f51ed5e686d299574e5afec35b9d20e..9390e96a9d19aeccdb5f9f552af9117522efb41f 100644 (file)
@@ -338,9 +338,8 @@ static char * vxfs_compact_buf(char *e_buf, int *new_count, int count,
 static bool vxfs_compare_acls(char *e_buf, char *n_buf, int n_count,
                              int e_count) {
 
-       uint16_t e_type, n_type, e_perm, n_perm;
-       uint32_t e_id, n_id;
-       int i, offset = 0;
+       uint16_t e_type, n_type;
+       int offset = 0;
 
        if (!e_buf && !n_buf) {
                DEBUG(10, ("vfs_vxfs: Empty buffers!\n"));
@@ -404,7 +403,7 @@ static bool vxfs_compare(struct files_struct *fsp,
 {
        SMB_ACL_T existing_acl = NULL;
        bool ret = false;
-       int i, count = 0;
+       int count = 0;
        TALLOC_CTX *mem_ctx = talloc_tos();
        char *existing_buf = NULL, *new_buf = NULL, *compact_buf = NULL;
        int status;