]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tracing: Remove unnecessary check for EVENT_FILE_FL_FREED
authorPetr Pavlu <petr.pavlu@suse.com>
Thu, 19 Feb 2026 16:27:03 +0000 (17:27 +0100)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 24 Mar 2026 00:16:45 +0000 (20:16 -0400)
The event_filter_write() function calls event_file_file() to retrieve
a trace_event_file associated with a given file struct. If a non-NULL
pointer is returned, the function then checks whether the trace_event_file
instance has the EVENT_FILE_FL_FREED flag set. This check is redundant
because event_file_file() already performs this validation and returns NULL
if the flag is set. The err value is also already initialized to -ENODEV.

Remove the unnecessary check for EVENT_FILE_FL_FREED in
event_filter_write().

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Tom Zanussi <zanussi@kernel.org>
Link: https://patch.msgid.link/20260219162737.314231-4-petr.pavlu@suse.com
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 249d1cba72c07dc84132efb366f555db8f923422..26d1e95a55d1cc632b75366697eabe4355b8d0fa 100644 (file)
@@ -2247,12 +2247,8 @@ event_filter_write(struct file *filp, const char __user *ubuf, size_t cnt,
 
        mutex_lock(&event_mutex);
        file = event_file_file(filp);
-       if (file) {
-               if (file->flags & EVENT_FILE_FL_FREED)
-                       err = -ENODEV;
-               else
-                       err = apply_event_filter(file, buf);
-       }
+       if (file)
+               err = apply_event_filter(file, buf);
        mutex_unlock(&event_mutex);
 
        kfree(buf);