]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-153068: Preserve cprofile enable errors (GH-153070) (#153242)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Tue, 7 Jul 2026 00:03:12 +0000 (02:03 +0200)
committerGitHub <noreply@github.com>
Tue, 7 Jul 2026 00:03:12 +0000 (00:03 +0000)
Lib/test/test_cprofile.py
Misc/NEWS.d/next/Library/2026-07-05-16-09-31.gh-issue-153068.huY9Jh.rst [new file with mode: 0644]
Modules/_lsprof.c

index 57e818b1c68b3881a9535ca1a19effbd2a0d8d6b..c903ecd5f65756e1016a49b9ce95db0b8095a3b9 100644 (file)
@@ -118,8 +118,9 @@ class CProfileTest(ProfileTest):
         pr = self.profilerclass()
         pr2 = self.profilerclass()
         pr.enable()
-        self.assertRaises(ValueError, pr2.enable)
-        pr.disable()
+        self.addCleanup(pr.disable)
+        msg = f"tool {sys.monitoring.PROFILER_ID} is already in use"
+        self.assertRaisesRegex(ValueError, msg, pr2.enable)
 
     def test_throw(self):
         """
diff --git a/Misc/NEWS.d/next/Library/2026-07-05-16-09-31.gh-issue-153068.huY9Jh.rst b/Misc/NEWS.d/next/Library/2026-07-05-16-09-31.gh-issue-153068.huY9Jh.rst
new file mode 100644 (file)
index 0000000..accf6e9
--- /dev/null
@@ -0,0 +1,2 @@
+Fix :meth:`!cProfile.Profile.enable` to no longer overwrite errors from
+:mod:`sys.monitoring`.
index 73602723d19bcf6545a60a419b355b9aaf83d01e..412909cd9bf39dfa00c91acd85c71889444f844d 100644 (file)
@@ -819,7 +819,6 @@ _lsprof_Profiler_enable_impl(ProfilerObject *self, int subcalls,
                                           "use_tool_id", "is",
                                           self->tool_id, "cProfile");
     if (check == NULL) {
-        PyErr_Format(PyExc_ValueError, "Another profiling tool is already active");
         goto error;
     }
     Py_DECREF(check);