pg_dump: check for _beginthreadex() failure in parallel dump

ParallelBackupStart() stored _beginthreadex()'s return value as the
worker's thread handle without checking it.  On failure that value is 0,
which would later reach WaitForMultipleObjects() as a null handle, caught
only by an Assert.  The fork() path already calls pg_fatal() when it
fails; do the same for _beginthreadex(), as pgbench does.

Author: Bryan Green <dbryan.green@gmail.com>
Discussion: https://www.postgresql.org/message-id/8c712d76-ecf7-4749-a6d8-dddc01f298ec@gmail.com
Backpatch-through: 14

diff --git a/src/bin/pg_dump/parallel.c b/src/bin/pg_dump/parallel.c
index f1577e785fafeacc2ff24c0b0b484e3c308bcdfd..323a97c69ba7806e3f530325d1d8af23ba367594 100644 (file)
--- a/src/bin/pg_dump/parallel.c
+++ b/src/bin/pg_dump/parallel.c
@@ -979,6 +979,8 @@ ParallelBackupStart(ArchiveHandle *AH)
 
                handle = _beginthreadex(NULL, 0, (void *) &init_spawned_worker_win32,
                                                                wi, 0, &(slot->threadId));
+               if (handle == 0)
+                       fatal("could not create worker thread: %m");
                slot->hThread = handle;
                slot->workerStatus = WRKR_IDLE;
 #else                                                  /* !WIN32 */