]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Note that threadpool_queue_work...() can't actually return NULL
authorNick Mathewson <nickm@torproject.org>
Thu, 27 Jul 2017 20:11:58 +0000 (16:11 -0400)
committerNick Mathewson <nickm@torproject.org>
Thu, 27 Jul 2017 20:28:59 +0000 (16:28 -0400)
src/common/workqueue.c

index f44f566d21b5873ef893e8a182f6576725634aaa..d1303ee0e3e2af863cc05231cbcfc035e5db33eb 100644 (file)
@@ -360,7 +360,8 @@ workerthread_new(int32_t lower_priority_chance,
  * function's responsibility to free the work object.
  *
  * On success, return a workqueue_entry_t object that can be passed to
- * workqueue_entry_cancel(). On failure, return NULL.
+ * workqueue_entry_cancel(). On failure, return NULL.  (Failure is not
+ * currently possible, but callers should check anyway.)
  *
  * Items are executed in a loose priority order -- each thread will usually
  * take from the queued work with the highest prioirity, but will occasionally