samba_upgradedns: Create binddns_dir if it doesn't already exist

Without doing this, the upgrade process can fail if the directory is not
present, e.g. after restoring from an offline backup (which specifically
ignores this directory).

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/source4/scripting/bin/samba_upgradedns b/source4/scripting/bin/samba_upgradedns
index fc995648226851e1be8ce71142e4c6658e3e24c6..a3d515c0df3a9ec1fcd8f29579727c45434f3322 100755 (executable)
--- a/source4/scripting/bin/samba_upgradedns
+++ b/source4/scripting/bin/samba_upgradedns
@@ -492,6 +492,10 @@ if __name__ == '__main__':
         else:
             logger.info("dns-%s account already exists" % hostname)
 
+        if not os.path.exists(paths.binddns_dir):
+            # This directory won't exist if we're restoring from an offline backup.
+            os.mkdir(paths.binddns_dir, 0o770)
+
         private_dns_keytab_path = os.path.join(paths.private_dir, paths.dns_keytab)
         bind_dns_keytab_path = os.path.join(paths.binddns_dir, paths.dns_keytab)