resolved: tests for dns_answer_add(), dns_answer_match_key()

diff --git a/src/resolve/meson.build b/src/resolve/meson.build
index 4fc2bc8006e6e5bab3e32ef13730e89c97dee3c2..c48227467e66711a677bc77965b51fd1d6dccd25 100644 (file)
--- a/src/resolve/meson.build
+++ b/src/resolve/meson.build
@@ -162,6 +162,9 @@ executables += [
         resolve_test_template + {
                 'sources' : files('test-resolve-tables.c'),
         },
+        resolve_test_template + {
+                'sources' : files('test-dns-answer.c'),
+        },
         resolve_test_template + {
                 'sources' : files('test-dns-packet.c'),
         },

diff --git a/src/resolve/test-dns-answer.c b/src/resolve/test-dns-answer.c
new file mode 100644 (file)
index 0000000..f0a0749
--- /dev/null
+++ b/src/resolve/test-dns-answer.c
@@ -0,0 +1,126 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+
+#include "dns-type.h"
+#include "resolved-dns-answer.h"
+#include "resolved-dns-rr.h"
+
+#include "log.h"
+#include "tests.h"
+
+/* ================================================================
+ * dns_answer_add()
+ * ================================================================ */
+
+TEST(dns_answer_add_a) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL;
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
+
+        answer = dns_answer_new(0);
+        ASSERT_NOT_NULL(answer);
+
+        rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(rr);
+        rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
+        dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        ASSERT_TRUE(dns_answer_contains(answer, rr));
+}
+
+/* ================================================================
+ * dns_answer_match_key()
+ * ================================================================ */
+
+TEST(dns_answer_match_key_single) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL;
+        DnsResourceKey *key = NULL;
+        _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
+        DnsAnswerFlags flags = 0;
+
+        answer = dns_answer_new(0);
+        ASSERT_NOT_NULL(answer);
+
+        rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(rr);
+        rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
+        dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, NULL);
+
+        ASSERT_EQ(dns_answer_size(answer), 1u);
+
+        ASSERT_TRUE(dns_answer_match_key(answer, rr->key, NULL));
+
+        ASSERT_TRUE(dns_answer_match_key(answer, rr->key, &flags));
+        ASSERT_EQ((int)flags, DNS_ANSWER_CACHEABLE);
+
+        /* ANY class matches */
+        key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, NULL));
+        dns_resource_key_unref(key);
+
+        /* ANY type matches */
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_ANY, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, NULL));
+        dns_resource_key_unref(key);
+
+        /* non-matching type */
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_FALSE(dns_answer_match_key(answer, key, NULL));
+        dns_resource_key_unref(key);
+
+        /* name is case-insensitive */
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "WWW.EXAMPLE.COM");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, NULL));
+        dns_resource_key_unref(key);
+
+        /* non-matching name */
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_FALSE(dns_answer_match_key(answer, key, NULL));
+        dns_resource_key_unref(key);
+
+        /* name containing an error */
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.\\example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, NULL) == -EINVAL);
+        dns_resource_key_unref(key);
+}
+
+TEST(dns_answer_match_key_multiple) {
+        _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL;
+        DnsResourceKey *key = NULL;
+        DnsResourceRecord *rr = NULL;
+        DnsAnswerFlags shared_flags = DNS_ANSWER_SECTION_ANSWER, ret_flags = 0;
+
+        answer = dns_answer_new(0);
+        ASSERT_NOT_NULL(answer);
+
+        rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_TXT, "www.example.com");
+        ASSERT_NOT_NULL(rr);
+        dns_answer_add(answer, rr, 1, shared_flags | DNS_ANSWER_AUTHENTICATED, NULL);
+        dns_resource_record_unref(rr);
+
+        rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(rr);
+        rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
+        dns_answer_add(answer, rr, 1, shared_flags | DNS_ANSWER_CACHEABLE, NULL);
+        dns_resource_record_unref(rr);
+
+        ASSERT_EQ(dns_answer_size(answer), 2u);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, &ret_flags));
+        ASSERT_EQ(ret_flags, shared_flags | DNS_ANSWER_CACHEABLE);
+        dns_resource_key_unref(key);
+
+        key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_ANY, "www.example.com");
+        ASSERT_NOT_NULL(key);
+        ASSERT_TRUE(dns_answer_match_key(answer, key, &ret_flags));
+        ASSERT_EQ(ret_flags, shared_flags);
+        dns_resource_key_unref(key);
+}
+
+DEFINE_TEST_MAIN(LOG_DEBUG);