]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
powerpc/xive: Fix refcount leak in xive_get_max_prio
authorMiaoqian Lin <linmq006@gmail.com>
Sun, 5 Jun 2022 05:32:23 +0000 (09:32 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:15:25 +0000 (11:15 +0200)
[ Upstream commit 255b650cbec6849443ce2e0cdd187fd5e61c218c ]

of_find_node_by_path() returns a node pointer with
refcount incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: eac1e731b59e ("powerpc/xive: guest exploitation of the XIVE interrupt controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605053225.56125-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/powerpc/sysdev/xive/spapr.c

index 5566bbc86f4afda058fc7ce77446baf11c2b07d7..aa705732150cc472b33d4d3317086699d538e1f8 100644 (file)
@@ -631,6 +631,7 @@ static bool xive_get_max_prio(u8 *max_prio)
        }
 
        reg = of_get_property(rootdn, "ibm,plat-res-int-priorities", &len);
+       of_node_put(rootdn);
        if (!reg) {
                pr_err("Failed to read 'ibm,plat-res-int-priorities' property\n");
                return false;