]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: fix TEST-84-STORAGETM with nvme-cli < 2.7
authorLuca Boccassi <luca.boccassi@gmail.com>
Wed, 28 May 2025 22:48:27 +0000 (23:48 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Thu, 29 May 2025 01:17:42 +0000 (02:17 +0100)
The -vv parameter was added in version 2.7, check before using it

Follow-up for ebc0514a6507d51e536b269e30a036a7992beeb7

(cherry picked from commit 60491ceb12aac9f2b9423490158bd9291d735b36)

test/units/TEST-84-STORAGETM.sh

index 3e286f45c0ac04d426bf7eebf126ae35e011a7cf..921bc1d2508c097c4d99fe38bd346a3a6ee86654 100755 (executable)
@@ -11,6 +11,11 @@ if systemd-analyze compare-versions "$(nvme --version | grep libnvme | awk '{pri
     fi
 fi
 
+VERBOSE=""
+if systemd-analyze compare-versions "$(nvme --version | grep '^nvme' | awk '{print $3}')" ge 2.7; then
+    VERBOSE="-vv"
+fi
+
 /usr/lib/systemd/systemd-storagetm --list-devices
 
 modprobe -v nvmet-tcp
@@ -24,7 +29,7 @@ NVME_UUID="$(cat /proc/sys/kernel/random/uuid)"
 systemd-run -u teststoragetm.service -p Type=notify -p "Environment=SYSTEMD_NVME_UUID=${NVME_UUID:?}" /usr/lib/systemd/systemd-storagetm /var/tmp/storagetm.test --nqn=quux
 NVME_DEVICE="/dev/disk/by-id/nvme-uuid.${NVME_UUID:?}"
 
-nvme connect-all -vv -t tcp -a 127.0.0.1 -s 16858 --hostnqn="$(nvme gen-hostnqn)"
+nvme connect-all "${VERBOSE}" -t tcp -a 127.0.0.1 -s 16858 --hostnqn="$(nvme gen-hostnqn)"
 udevadm wait --settle "$NVME_DEVICE"
 
 dd if="$NVME_DEVICE" bs=1024 | cmp /var/tmp/storagetm.test -