]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: tegra-mc: Simplify printing PTR_ERR with dev_err_probe
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thu, 26 Feb 2026 20:35:26 +0000 (21:35 +0100)
committerKrzysztof Kozlowski <krzk@kernel.org>
Thu, 5 Mar 2026 11:54:58 +0000 (12:54 +0100)
Use dev_err_probe() to simplify the code and fix Coccinelle warning:

  tegra/mc.c:513:52-59: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Link: https://patch.msgid.link/20260226-memory-simplify-v1-3-ccb94f378628@oss.qualcomm.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
drivers/memory/tegra/mc.c

index c33f514fc8049e1ad1a9499e08379285fee8e349..1dc516a5be149cda851cf11371c2ac62b57c445c 100644 (file)
@@ -507,10 +507,9 @@ int tegra30_mc_probe(struct tegra_mc *mc)
        int err;
 
        mc->clk = devm_clk_get_optional(mc->dev, "mc");
-       if (IS_ERR(mc->clk)) {
-               dev_err(mc->dev, "failed to get MC clock: %ld\n", PTR_ERR(mc->clk));
-               return PTR_ERR(mc->clk);
-       }
+       if (IS_ERR(mc->clk))
+               return dev_err_probe(mc->dev, PTR_ERR(mc->clk),
+                                    "failed to get MC clock\n");
 
        /* ensure that debug features are disabled */
        mc_writel(mc, 0x00000000, MC_TIMING_CONTROL_DBG);
@@ -518,10 +517,8 @@ int tegra30_mc_probe(struct tegra_mc *mc)
        tegra_mc_setup_latency_allowance(mc);
 
        err = tegra_mc_setup_timings(mc);
-       if (err < 0) {
-               dev_err(mc->dev, "failed to setup timings: %d\n", err);
-               return err;
-       }
+       if (err < 0)
+               return dev_err_probe(mc->dev, err, "failed to setup timings\n");
 
        return 0;
 }